Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: simplify wildcard routes (#124) #125

Merged
merged 2 commits into from
Jan 23, 2023
Merged

refactor: simplify wildcard routes (#124) #125

merged 2 commits into from
Jan 23, 2023

Conversation

peter-gy
Copy link
Collaborator

@peter-gy peter-gy commented Jan 22, 2023 •
edited
Loading

Goals

  • Replace the hard-coded dynamic nested URL rule generation - based approach to catch requests arriving to /api/* and forward it to Stemmarest.

Notes

Reworks ea9dce2 introduced in #105.

Closes #124

@peter-gy
refactor(middleware): catch wildcard routes explicitly
642b375 
Replaces the hard-coded nested URL generating approach.
Catches every request arriving to `/api/*`
@peter-gy
refactor(middleware): cleanup obsolete StemmarestEndpoints class
0c3bf17 
Generating routes dynamically is not needed anymore.
@peter-gy peter-gy requested a review from tla January 22, 2023 20:12
tla
tla approved these changes Jan 23, 2023
View reviewed changes
Copy link
Owner

@tla tla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this so quickly!

@tla tla merged commit d90e4f1 into d3bootstrap Jan 23, 2023
@peter-gy peter-gy mentioned this pull request Jan 23, 2023
Closed
@peter-gy peter-gy deleted the refactor/wildcard-routes branch January 31, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tla tla tla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peter-gy @tla