Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix for dask 2024.8 #240

Merged
merged 1 commit into from
Sep 11, 2024
Merged

fix: fix for dask 2024.8 #240

merged 1 commit into from
Sep 11, 2024

Conversation

tlambert03
Copy link
Owner

closes #239

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.97%. Comparing base (a515efd) to head (4ca706c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #240      +/-   ##
==========================================
+ Coverage   94.92%   94.97%   +0.05%     
==========================================
  Files          18       18              
  Lines        2424     2429       +5     
==========================================
+ Hits         2301     2307       +6     
+ Misses        123      122       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Sep 11, 2024

CodSpeed Performance Report

Merging #240 will degrade performances by 21.17%

Comparing fix-dask (4ca706c) with main (a515efd)

Summary

❌ 2 regressions
✅ 11 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix-dask Change
test_time_imread_dask[dims_p2z5t3-2c4y32x32] 60.1 ms 72.8 ms -17.43%
test_time_imread_dask[jonas_control002] 778.9 ms 988.1 ms -21.17%

@tlambert03 tlambert03 merged commit d04df9b into main Sep 11, 2024
22 of 23 checks passed
@tlambert03 tlambert03 deleted the fix-dask branch September 11, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning about garbage collection, even with "with", with dask 2024.8
1 participant