Fixes issue with SAMLSignature method not using default transformations #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ansformations when none is passed in the options but then this code ignores the defaults and uses the ones from the options passed which could be undefined. The addReference then possibly passes an undefined transformations which xml-crypto library only adds 'http://www.w3.org/2001/10/xml-exc-c14n#' instead of 'http://www.w3.org/2001/10/xml-exc-c14n#' and 'http://www.w3.org/2000/09/xmldsig#enveloped-signature' defined in this codebase's constructSAMLSignature.
tngan
approved these changes
Apr 10, 2022
This was referenced Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be a bug where the method sets up a default array of transformations when none is passed in the options but then this code ignores the defaults and uses the ones from the options passed which could be undefined. The addReference then possibly passes an undefined transformations which xml-crypto library only adds 'http://www.w3.org/2001/10/xml-exc-c14n#' instead of 'http://www.w3.org/2001/10/xml-exc-c14n#' and 'http://www.w3.org/2000/09/xmldsig#enveloped-signature' defined in this codebase's constructSAMLSignature.