Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract sessionIndex from LogoutRequest #501

Merged

Conversation

zentooo
Copy link
Contributor

@zentooo zentooo commented Jan 4, 2023

Feature Request in PR form.

As SP/IdP, we have to identify session with SessionIndex when received LoginRequest.
So it is convenient to extract it with parseLogoutRequest.

@tngan tngan merged commit 215ed88 into tngan:master Jan 20, 2023
mastermatt added a commit to mastermatt/samlify that referenced this pull request Feb 14, 2023
Seems to have been accidentally added in tngan#501,
these never worked because `sessionIndex` is not part of the default logout request template,
so whether the extractor works or not, the creation of the request will not include the value.

And with this, the test suite passes again!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants