fix: escape backslashes in JSON formatter output #314
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, our JSON-formatted ouput is not actually valid JSON when it is rendered with unescaped backslashes like ".+@.+\..+". Signed-off-by: Jon Parise <jon@indelible.org>
jparise
force-pushed
the
json-formatter-escape-backslashes
branch
from
70527cd
to
8db98b6
Compare
|
Actually, scratch this. The problem I was seeing was due to some local, intermediate string processing that I had attributed to repolinter itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Our JSON-formatted ouput is not actually valid JSON when it is rendered with unescaped backslashes like ".+@.+..+".
Proposed Changes
The JsonFormatter uses
JSON.stringify()to render its output, but it needs additional postprocessing to escape backslashes.Test Plan
I added a unit test to exercise this new expected behavior.