Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update minimal Rust version #338

Merged
merged 1 commit into from
Apr 28, 2022
Merged

docs: Update minimal Rust version #338

merged 1 commit into from
Apr 28, 2022

Conversation

shanesveller
Copy link
Sponsor Contributor

@shanesveller shanesveller commented Apr 28, 2022

In #318, the CI version was changed to Rust 1.58+ and installation of tokio-console 0.1.4 on Rust 1.56-1.57 fails on that version as noted in the ci.yaml changes in commit 83d8a87.

Please let me know if there are any additional changes needed (i.e. version number bump due to altering rust-version in Cargo.toml or changelog entry), contribution process I overlooked , etc.

Thanks for this project!

In #318, the CI version was changed to Rust 1.58+ and installation of
tokio-console 0.1.4 on Rust 1.56-1.57 fails on that version as noted in
`ci.yaml` changes in commit 83d8a87.
@shanesveller shanesveller requested a review from a team as a code owner April 28, 2022 21:03
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching that!

it would be nice if we had some kind of automation/testing to ensure these are kept in sync with the version on ci...

@hawkw hawkw enabled auto-merge (squash) April 28, 2022 21:24
@hawkw hawkw merged commit ff3b6db into tokio-rs:main Apr 28, 2022
@shanesveller shanesveller deleted the shanesveller/msrv-doc-update branch April 28, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants