fix(prost-types): Parse timestamp with long second fraction #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`chrono` is able to parse timestamps which are more precise then nanoseconds. We can also do that but truncating the digits.
|
@mumbleskates I found this one while fuzzing against chrono |
|
nice! i haven't gotten around to looking at |
|
oh i see you're also parsing directly with chrono! i will try that also. |
mumbleskates
approved these changes
Jul 19, 2024
|
Hmm. What fuzzing condition did you enforce with this? There are so many differences between how this library parses dates (esp. the year) and how chrono does it that it's hard to assert that we parse a superset. did you just check that strings that parse with both libraries are equivalent? |
|
This is the fuzzing test I executed: caspermeijn@8dd7f4a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chronois able to parse timestamps which are more precise then nanoseconds. We can also do that but truncating the digits.