fix(prost-types): Format negative fractional duration #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mumbleskates I took a shot at fuzzing duration. It is difficult to find another implementation to compare to. But I found this bug at least. |
Duration `-0.123s` was formatted as a positive number.
caspermeijn
force-pushed
the
fix_format_duration
branch
from
ba5217c
to
f32a68c
Compare
|
oh nice! thank you. yes, the standards for time intervals i know of are fearsomely complicated and I'd be hesitant to make anything much more complicated. maybe adding hours and minutes would be friendly but it's not really necessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duration
-0.123swas formatted as a positive number.