must_use for JoinHandle::abort_handle #6761
Labels
A-tokio
Area: The main tokio crate
C-feature-request
Category: A feature request.
E-easy
Call for participation: Experience needed to fix: Easy / not much
E-help-wanted
Call for participation: Help is requested to fix this issue.
M-task
Module: tokio/task
Comments
incker
added
A-tokio
Darksonn
added
E-easy
|
Hey @Darksonn @incker, I can give it a go. Can you help me understand the expected behavior? From what I understood we just need to put must_use macro on abort_handle so that it gives warning whenever we are not using the value returned from abort_handle and the issue here is there is a case of mixup when folks are using abort_handle instead of abort and ignoring the return value? |
sainad2222
added a commit
to sainad2222/tokio
that referenced
this issue
Aug 9, 2024
if the return value of abort_handle is unused then abort will never be called for that JoinHandle Fixes: tokio-rs#6761
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello !
Can you please make
#[must_use]macro for functionJoinHandle::abort_handle(..)Because sometimes i mix up functions
JoinHandle::abort_handle(..)andJoinHandle::abort(..)Forward thank you!
The text was updated successfully, but these errors were encountered: