Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macros: Allow arguments in non-main functions #1594

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

DoumanAsh
Copy link
Contributor

@DoumanAsh DoumanAsh commented Sep 24, 2019

Removes restriction on arguments in non-main functions

We don't really return future, so lifetime should not be concern

P.s. these build tests are utter shite

@taiki-e
Copy link
Member

taiki-e commented Sep 24, 2019

P.s. these build tests are utter shite

I recommend using TRYBUILD=overwrite. I think this almost eliminates the pain of UI tests.

https://github.com/dtolnay/trybuild#workflow

Alternatively, run cargo test with the environment variable TRYBUILD=overwrite to skip the wip directory and write all compiler output directly in place.

@DoumanAsh
Copy link
Contributor Author

And I recommend to not use this shit at all ;0
I'll check it later

Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DoumanAsh DoumanAsh merged commit a1d1eb5 into tokio-rs:master Oct 1, 2019
@DoumanAsh DoumanAsh deleted the macros_args branch October 1, 2019 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants