Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stablize pin feature #814

Merged
merged 2 commits into from
Dec 28, 2018
Merged

Stablize pin feature #814

merged 2 commits into from
Dec 28, 2018

Conversation

balthild
Copy link
Contributor

Motivation

#813

Box::pinned has been renamed to Box::pin. Meanwhile, the pin feature no longer requires an attribute to enable.

Solution

Change Box::pinned(...) to Box::pin(...), and remove pin feature attribute.

@balthild
Stablize pin feature
f00a9ab 
Box::pinned has been renamed to Box::pin. Meanwhile, the pin feature
no longer requires an attribute to enable.

Fixes: #813
LucioFranco
LucioFranco approved these changes Dec 26, 2018
View reviewed changes
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 though for this people would need to be on the latest nightly as of 12-25-2018, so that may be something that should be added to the readme maybe?

@seanmonstar seanmonstar merged commit 03e2e86 into tokio-rs:master Dec 28, 2018
@balthild balthild deleted the stablize-pin branch December 29, 2018 05:25
@mehcode mehcode mentioned this pull request Jan 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

@LucioFranco LucioFranco LucioFranco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balthild @seanmonstar @LucioFranco