-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement enabled_span
and enabled_event
#1900
Merged
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ef715b9
implement `enabled_span` and `enabled_event`
guswynn 04075d5
enabled_event -> event_enable
guswynn 8f5a94e
improve {event,span}_enabled docs
guswynn 8716d98
cleanup rustdoc links for enabled
guswynn 497f318
switch macro impl to all being enabled
guswynn 43d54b5
docs and tests
guswynn 704ecf7
more doc tests
guswynn 1b0d66e
cleanup .hint usage
guswynn 1d3e8db
merge tests with set_default
guswynn e5b20bc
Merge branch 'master' into span_enabled
hawkw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
// liballoc is required because the test subscriber cannot be constructed | ||
// statically | ||
#![cfg(feature = "alloc")] | ||
|
||
mod support; | ||
|
||
use self::support::*; | ||
use tracing::Level; | ||
|
||
#[cfg_attr(target_arch = "wasm32", wasm_bindgen_test::wasm_bindgen_test)] | ||
#[test] | ||
fn span_and_event() { | ||
let collector = collector::mock() | ||
.with_filter(|meta| { | ||
if meta.target() == "debug_module" { | ||
meta.level() <= &Level::DEBUG | ||
} else if meta.is_span() { | ||
meta.level() <= &Level::TRACE | ||
} else if meta.is_event() { | ||
meta.level() <= &Level::DEBUG | ||
} else { | ||
meta.level() <= &Level::INFO | ||
} | ||
}) | ||
.done() | ||
.run(); | ||
|
||
tracing::collect::set_global_default(collector).unwrap(); | ||
|
||
// Ensure that the `_event` and `_span` alternatives work corretly | ||
assert!(!tracing::event_enabled!(Level::TRACE)); | ||
assert!(tracing::event_enabled!(Level::DEBUG)); | ||
assert!(tracing::span_enabled!(Level::TRACE)); | ||
|
||
// target variants | ||
assert!(tracing::span_enabled!(target: "debug_module", Level::DEBUG)); | ||
assert!(tracing::event_enabled!(target: "debug_module", Level::DEBUG)); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would probably use the local default (
set_default
) in these tests, so they can all be in the same file...having to put it in a separate file is kind of annoying. not a hard blocker though.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ill clean this up then merge!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rather, ill clean this up, then yall can squash-and-merge