Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance when display many markers and change icon #216

Closed
ga12ru12 opened this issue Feb 24, 2016 · 1 comment
Closed

Performance when display many markers and change icon #216

ga12ru12 opened this issue Feb 24, 2016 · 1 comment

Comments

@ga12ru12
Copy link

I load a map and display 1000 markers. It's ok. But when I random to change icon of these marker, it's so lag. Anyone can help me how to fix this pls? Tks
@tomchentw tomchentw mentioned this issue May 29, 2016
Open
@tomchentw
Copy link
Owner

We're going to look into this shortly. Close for now

We're also looking for maintainers. Involve in #266 to help strengthen our community!

tomchentw pushed a commit that referenced this issue May 30, 2016
@rewop @tomchentw
perf(src): switch mapHolderRef from props to context
c2d265c 
* Improved performance of rendering many markers/components on the map
* Closes #135
* Closes #210
* Closes #216

BREAKING CHANGE: If you're just using the library and didn't make custom components before, feel free to ignore this implementation changes.

Now, mapHolderRef for each component are now passed in via context. This doesn't affect all components interface in general. But if you do custom components before and relies on the implementation of react-google-maps, you should be aware of this and make some changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomchentw @ga12ru12