fix!: Make Key::from_str only accept Displays output
#273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I remember wanting to remove this before and had problems. It looks like those have since been addressed (I think with changes to repr). Before, we were taking any string and trying to infer what its repr would be. Now we only parse actualy dotted keys. This will hopefully help with rust-lang/cargo#10176 BREAKING CHANGE: `Key::from_str` will accept fewer values and will return slightly different errors.
epage
changed the title
Key::from_str only accept Displays outputKey::from_str only accept Displays output
epage
added
the
M-breaking-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I remember wanting to remove this before and had problems. It looks
like those have since been addressed (I think with changes to repr).
Before, we were taking any string and trying to infer what its repr
would be.
Now we only parse actualy dotted keys.
This will hopefully help with rust-lang/cargo#10176
BREAKING CHANGE:
Key::from_strwill accept fewer values and willreturn slightly different errors.