Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nicegram Wallet #52

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

denis-zhuravlev
Copy link

@denis-zhuravlev denis-zhuravlev commented Jun 11, 2024

Add Nicegram Wallet

Supports

  • HTTP bridge as a mobile wallet app for iOS and Android.
  • JS bridge for the in-wallet browser for iOS and Android.

Supported features

Integrator contacts

  • telegram @dz_it

@LetikGit
Copy link
Member

@denis-zhuravlev Hi. In the iOS version it just redirects to a 404 page. Please, recheck the functionality there https://ton-connect.github.io/demo-dapp-with-react-ui/

@denis-zhuravlev
Copy link
Author

@denis-zhuravlev Hi. In the iOS version it just redirects to a 404 page. Please, recheck the functionality there https://ton-connect.github.io/demo-dapp-with-react-ui/

Do you mean the universal url? Our wallet app updates are not yet released in production, do we need to release it first for you to be able to verify the expected behaviour?

@LetikGit
Copy link
Member

LetikGit commented Jun 13, 2024

Do you mean the universal url? Our wallet app updates are not yet released in production, do we need to release it first for you to be able to verify the expected behaviour?

Yes, please, comment here when updates will be released in the production version.

@denis-zhuravlev
Copy link
Author

Do you mean the universal url? Our wallet app updates are not yet released in production, do we need to release it first for you to be able to verify the expected behaviour?

Yes, please, comment here when updates will be released in the production version.

Hi, @LetikGit

We've released both iOS and Android (apk download only at the moment) versions of our app.

@LetikGit
Copy link
Member

We've released both iOS and Android (apk download only at the moment) versions of our app.

Hi @denis-zhuravlev

I have several problems:

  1. On iOS when I try to click on the "Connect" button (in the connection to dApp modal page) nothing happens
  2. On Android after entering the PIN code for the wallet nothing happens too

@denis-zhuravlev
Copy link
Author

We've released both iOS and Android (apk download only at the moment) versions of our app.

Hi @denis-zhuravlev

I have several problems:

  1. On iOS when I try to click on the "Connect" button (in the connection to dApp modal page) nothing happens
  2. On Android after entering the PIN code for the wallet nothing happens too
    Hi @LetikGit,

It happens due to this error in browser console, which happens (as far as I understand) because dApp can't find "nicegramWallet" in wallets list, and that makes sense because we have the pull request pending and our wallet is not yet in the list. We've tested our ton connect integration with tonkeeper credentials before release. Should we release with tonkeeper credentials for you to be able to verify? Or is there a way to make dapps load our credentials somehow before pr is merged?
image

@LetikGit
Copy link
Member

@denis-zhuravlev
Copy link
Author

denis-zhuravlev commented Jun 28, 2024

@denis-zhuravlev You can now test it here https://ton-connect.github.io/demo-dapp-with-react-ui/

@LetikGit Thanks! We've tested our Android and iOS apps with the demo dApp you provided, everything works fine. Make sure you have the latest apk for android (1.30.4), we've fixed the qr scanner for universal url with the latest update.

@LetikGit
Copy link
Member

LetikGit commented Jul 4, 2024

@LetikGit Thanks! We've tested our Android and iOS apps with the demo dApp you provided, everything works fine. Make sure you have the latest apk for android (1.30.4), we've fixed the qr scanner for universal url with the latest update.

Now wallet connecting is working, but sending transaction doesn't work fine. It shows empty values. (iOS, the latest version from the store)
Also there is no redirect to dApp after successful wallet connecting.

Please, check these problems in the sandbox.

@weixuefeng
Copy link
Contributor

weixuefeng commented Jul 12, 2024

how can i know the origin app? @LetikGit

@denis-zhuravlev
Copy link
Author

Hi, @LetikGit, thank you for you feedback

We've tested again and everything works fine, could you please specify more details about empty values? Indeed we had no "ret" param processing, added the processing in the latest versions (iOS version in app store, android with the fresh apk by the link).
We've noticed there is no "ret" param when using demo app in iOS browser, therefore no redirects there.
Also I'm sharing the link with demo videos on android and iOS maybe it will be easier for you to point out on the mistakes you encounter. https://drive.google.com/drive/folders/1FkKP1GKaZXHrzLWBBELqGZ-pUB4YF589

If there are still some issues, would be great if you could contact me in telegram @dz_it so we could resolve it faster, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants