chore: pin TS 3.3 because of performance of 3.4 #338
Conversation
There was a problem hiding this comment.
Oh, this is sooo bad from Microsoft side...
Thanks for finding this @havenchyk ! It's amazing! 🚀
Edit: irresponsible... this is the word :)
|
Successfully deployed demo at https://picasso.toptal.net/revert-ts-3.3 |
|
❤️ Oh wow @havenchyk you are killer |
havenchyk
force-pushed
the
revert-ts-3.3
branch
2 times, most recently
from
3fe9718
to
e9f86ed
Compare
havenchyk
changed the title
|
Successfully deployed demo at https://picasso.toptal.net/revert-ts-3.3 |
|
Update: reverting |
| @@ -128,7 +128,7 @@ | |||
| "styled-components": "^4.2.0", | |||
| "ts-jest": "^24.0.2", | |||
| "ts-loader": "^5.4.5", | |||
| "typescript": "^3.4.5", | |||
| "typescript": "3.3.4000", | |||
There was a problem hiding this comment.
Can we set alert to remind us to try it again for 3.5 or 3.4.6?
There was a problem hiding this comment.
I think we'll receive a PR from @depfu, I'll create a jira ticket as a reminder :)
There was a problem hiding this comment.
|
Successfully deployed demo at https://picasso.toptal.net/revert-ts-3.3 |
|
🎉 This PR is included in version 1.5.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Successfully deployed demo at https://picasso.toptal.net/revert-ts-3.3 |
Description
There is an issue with TS microsoft/TypeScript#30819 that in conjunction with latest updates of
@types/reactslows down our storybook build.Long read about how that happened
Results after reverting packages on my machine
Caveats
yarn build:storybooktakes a couple of seconds more with@types/react@16.8.14Be sure we don't use features that work only in
3.4+TS - https://github.com/Microsoft/TypeScript/wiki/Breaking-Changes#typescript-34Next version
3.5works better, but still has worse performance than3.3, upgrade should be considered after the releaseHow to test
rm -rf node_modules && yarn && yarn storybookand check timeReview
- [ ] Annotate allpropsin component with documentation- [ ] Createexamplesfor component- [ ] Ensure that visuals specs are green See the documentation