Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long line in the torrents description are rendered outside of the description div #525

Closed
josecelano opened this issue Apr 18, 2024 · 2 comments · Fixed by #531 or #535
Closed

Long line in the torrents description are rendered outside of the description div #525

josecelano opened this issue Apr 18, 2024 · 2 comments · Fixed by #531 or #535
Labels
Bug Incorrect Behavior Easy Good for Newcomers good first issue Good for newcomers UI User Interface
Milestone
v3.0.0

Comments

@josecelano
Copy link
Member

image
@josecelano josecelano added Bug Incorrect Behavior UI User Interface labels Apr 18, 2024
@josecelano josecelano added this to the v3.0.0 milestone Apr 18, 2024
@josecelano josecelano added Easy Good for Newcomers good first issue Good for newcomers labels Apr 18, 2024
hungfnt added a commit to hungfnt/torrust-index-gui that referenced this issue Apr 22, 2024
@hungfnt
fix:[torrust#525] add break-words to torrent component tab
769a832
@josecelano josecelano linked a pull request Apr 22, 2024 that will close this issue
fix:[#525] add break-words to torrent component tab #531
Merged
josecelano added a commit that referenced this issue Apr 22, 2024
@josecelano
Merge #531: fix:[#525] add break-words to torrent component tab
13e1f03 
769a832 fix:[#525] add break-words to torrent component tab (ngthhu)

Pull request description:

ACKs for top commit:
  josecelano:
    ACK 769a832

Tree-SHA512: 0dd7250fe98453e7efd53e96cb5ad069e6365622f23dce3f80011a1d29e3affd9860409984a92efb156b4f2e7fc18ceb829d06f921844be6e72eb566c1942490
@hungfnt
Copy link
Contributor

hungfnt commented Apr 23, 2024 •
edited
Loading

Hey, I noticed the descriptions for each torrent in the list weren't word-wrapped. I'm adding it now.
We can use the class break-words in Markdown instead of all Tab components.

@hungfnt
Copy link
Contributor

hungfnt commented Apr 23, 2024 •
edited
Loading

The markdown width should be inherit from parent div.

image

When I use class="prose max-w-none text-justify break-words" for div of Markdown, everything is good except the overflow word.

With break-all, the long-word case is handled well, but normal paragraphs lose readability.

Followed this solution, 2 cases are good.

hungfnt added a commit to hungfnt/torrust-index-gui that referenced this issue Apr 23, 2024
@hungfnt
fix:[torrust#525] more efficient solution
5c31ef4
hungfnt added a commit to hungfnt/torrust-index-gui that referenced this issue Apr 23, 2024
@hungfnt
fix:[torrust#525] custom word-wrap css class
3bdd25f
hungfnt added a commit to hungfnt/torrust-index-gui that referenced this issue Apr 24, 2024
@hungfnt
fix:[torrust#525] more efficient solution
11478f9 
fix:[torrust#525] custom word-wrap css class

lint fix
@josecelano josecelano linked a pull request Apr 24, 2024 that will close this issue
fix:[#525] more efficient solution #535
Merged
josecelano added a commit that referenced this issue Apr 24, 2024
@josecelano
Merge #535: fix:[#525] more efficient solution
0d834cc 
11478f9 fix:[#525] more efficient solution (ngthhu)

Pull request description:

ACKs for top commit:
  josecelano:
    ACK 585447a

Tree-SHA512: 4aa664c7fabcac6a523c1588518452d90b16b368e9075434f89ce70fb1ec88b74c66a3ad622e51b5eca002551c6f6315a8538d900a877d2522bf6e8ec80fd120
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Incorrect Behavior Easy Good for Newcomers good first issue Good for newcomers UI User Interface
Projects
Torrust Solution
Status: No status
Milestone
v3.0.0
2 participants
@josecelano @hungfnt