-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration overhaul: replace primitive types in configuration with richer types #600
Merged
josecelano
merged 9 commits into
torrust:develop
from
josecelano:599-configuration-overhaul-replace-primitive-types-in-configuration-with-richer-types
May 24, 2024
Merged
Commits on May 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c7c9225 - Browse repository at this point
Copy the full SHA c7c9225View commit details -
refactor: [torrust#599] extract types for torrust_index::config::v1::…
…database::Database
Configuration menu - View commit details
-
Copy full SHA for 28617b6 - Browse repository at this point
Copy the full SHA 28617b6View commit details -
chore(deps): enable serialization for lettre
We will use the type `Mailbox` in the configuration and it needs to be serializable.
Configuration menu - View commit details
-
Copy full SHA for 748f357 - Browse repository at this point
Copy the full SHA 748f357View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7edbf7c - Browse repository at this point
Copy the full SHA 7edbf7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c422e52 - Browse repository at this point
Copy the full SHA c422e52View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab4717d - Browse repository at this point
Copy the full SHA ab4717dView commit details -
refactor: [torrust#599] use URL type for connect_url in database config
We were using a cusomt type but sqlx defines it as a URL. WE can validate this type in the configration and let the app domain validate if the connection URL is a valid one. For example, if the app supports the database driver. Otherwise we have to change this first level valitation anytime we support a new DB.
Configuration menu - View commit details
-
Copy full SHA for b1d5267 - Browse repository at this point
Copy the full SHA b1d5267View commit details
Commits on May 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8e53982 - Browse repository at this point
Copy the full SHA 8e53982View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec1d39a - Browse repository at this point
Copy the full SHA ec1d39aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.