Merge #726: Fix linting errors

f9a5f7e chore: fix linting errors (Jose Celano)

Pull request description:

  Fix linting errors.

ACKs for top commit:
  josecelano:
    ACK f9a5f7e

Tree-SHA512: 8dd481815888aa0b752f82568f9fd61fa4a3d9d6e0c7eb03deb360985f9196845295badd98bdbc87fdd60c49b5f94575965c4475b62237f82612d5028a7123ef

packages/configuration/src/lib.rs

@@ -475,7 +475,7 @@ pub struct Configuration {
     /// peers from the torrent peer list.
     pub inactive_peer_cleanup_interval: u64,
     /// If enabled, the tracker will remove torrents that have no peers.
-    /// THe clean up torrent job runs every `inactive_peer_cleanup_interval`
+    /// The clean up torrent job runs every `inactive_peer_cleanup_interval`
     /// seconds and it removes inactive peers. Eventually, the peer list of a
     /// torrent could be empty and the torrent will be removed if this option is
     /// enabled.

packages/primitives/src/lib.rs

@@ -19,7 +19,7 @@ pub enum DatabaseDriver {
     // TODO: Move to the database crate once that gets its own crate.
     /// The Sqlite3 database driver.
     Sqlite3,
-    /// The MySQL database driver.
+    /// The `MySQL` database driver.
     MySQL,
 }
 

packages/test-helpers/src/configuration.rs

@@ -55,7 +55,7 @@ pub fn ephemeral() -> Configuration {
     let temp_directory = env::temp_dir();
     let random_db_id = random::string(16);
     let temp_file = temp_directory.join(format!("data_{random_db_id}.db"));
-    config.db_path = temp_file.to_str().unwrap().to_owned();
+    temp_file.to_str().unwrap().clone_into(&mut config.db_path);
 
     config
 }
@@ -138,8 +138,8 @@ pub fn ephemeral_ipv6() -> Configuration {
 
     let ipv6 = format!("[::]:{}", 0);
 
-    cfg.http_api.bind_address = ipv6.clone();
-    cfg.http_trackers[0].bind_address = ipv6.clone();
+    cfg.http_api.bind_address.clone_from(&ipv6);
+    cfg.http_trackers[0].bind_address.clone_from(&ipv6);
     cfg.udp_trackers[0].bind_address = ipv6;
 
     cfg

src/servers/udp/error.rs

@@ -13,7 +13,7 @@ pub enum Error {
         source: LocatedError<'static, dyn std::error::Error + Send + Sync>,
     },
 
-    /// Error returned from a third-party library (aquatic_udp_protocol).
+    /// Error returned from a third-party library (`aquatic_udp_protocol`).
     #[error("internal server error: {message}, {location}")]
     InternalServer {
         location: &'static Location<'static>,