Skip to content

Commit

Permalink
Merge #474: ci: re-enable llvm-cov coverage
Browse files Browse the repository at this point in the history
be914b6 ci: re-enable llvm-cov coverage (Cameron Garnham)
4ca47a4 fixup: ignore new clippy warning (Cameron Garnham)

Pull request description:

  Upstream time-rs/time#618 is fixed.

ACKs for top commit:
  da2ce7:
    ACK be914b6

Tree-SHA512: 2def2d37af211694c201b13b47634403dc2f13281b32cb3129dbd1b3d53a7838a6d35f1b92d1e0a6bc8e588d481ddec78749af68d4c366c70444017dcb5182c3
  • Loading branch information
da2ce7 committed Oct 8, 2023
2 parents 14b1dca + be914b6 commit d415939
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 5 deletions.
7 changes: 3 additions & 4 deletions .github/workflows/testing.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ jobs:
name: Run Unit Tests
run: cargo test --tests --benches --examples --workspace --all-targets --all-features

# Temporary Disable https://github.com/time-rs/time/issues/618
# - id: coverage
# name: Generate Coverage Report
# run: cargo llvm-cov nextest --tests --benches --examples --workspace --all-targets --all-features
- id: coverage
name: Generate Coverage Report
run: cargo llvm-cov nextest --tests --benches --examples --workspace --all-targets --all-features
2 changes: 1 addition & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"-W",
"clippy::style",
"-W",
"clippy::pedantic",
"clippy::pedantic"
],
"evenBetterToml.formatter.allowedBlankLines": 1,
"evenBetterToml.formatter.columnWidth": 130,
Expand Down
8 changes: 8 additions & 0 deletions contrib/bencode/src/access/list.rs
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,14 @@ impl<'a, V: 'a> IndexMut<usize> for &'a mut dyn BListAccess<V> {
}
}

impl<'a, V: 'a> dyn BListAccess<V> {
pub fn iter(&'a self) -> impl Iterator<Item = &'a V> {
self.into_iter()
}
}

#[allow(unknown_lints)]
#[allow(clippy::into_iter_without_iter)]
impl<'a, V: 'a> IntoIterator for &'a dyn BListAccess<V> {
type Item = &'a V;
type IntoIter = BListIter<'a, V>;
Expand Down
2 changes: 2 additions & 0 deletions contrib/bencode/src/error.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#![allow(unknown_lints)]
#![allow(clippy::iter_without_into_iter)]
use error_chain::error_chain;

error_chain! {
Expand Down

0 comments on commit d415939

Please sign in to comment.