-
Notifications
You must be signed in to change notification settings - Fork 41
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge #858: Use only non-defaults in
toml
config templates
445bd53 feat: define only non-defaults in toml config templates (Jose Celano) Pull request description: After implementing the configuration with Figment, it's possible to omit values if they are defaults. Therefore, we don't need to add all options in templates. We only need to add values that overwrite the default values. For example, the new configuration file for development environment (`share/default/config/tracker.development.sqlite3.toml`) is: ```toml [[udp_trackers]] enabled = true [[http_trackers]] enabled = true ``` The only difference with the default values is UDP and HTTP services are enabled. This makes it easier to maintain these templates and to see what changes have been made compared to the default values. ACKs for top commit: josecelano: ACK 445bd53 Tree-SHA512: 0f2367adf49bc87669c49662c3203d513bde7f9c821638dca6149de7c31759a8e6243af8a857e7227f154920be43f63b19b0d7e25858748658be362010628a32
- Loading branch information
Showing
11 changed files
with
169 additions
and
185 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.