Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for Tracker #207

Closed
Tracked by #160
josecelano opened this issue Mar 1, 2023 · 1 comment · Fixed by #210
Closed
Tracked by #160

Add unit tests for Tracker #207

josecelano opened this issue Mar 1, 2023 · 1 comment · Fixed by #210
Labels
Quality & Assurance Relates to QA, Testing, and CI

Comments

@josecelano
Copy link
Member

josecelano commented Mar 1, 2023 •
edited
Loading

Parent issue: #160

The core' Tracker' struct has new responsibilities in the new Axum implementation for the HTTP tracker. New methods were added like: announce, scrape, authenticate, requires_authentication, empty_scrape_for.

I want to add tests for them because they are only indirectly tested now by integration tests.

In general, I will improve the test coverage for the Axum Tracker.
@josecelano josecelano added the Quality & Assurance Relates to QA, Testing, and CI label Mar 1, 2023
@josecelano josecelano mentioned this issue Mar 1, 2023
Closed
17 tasks
@josecelano josecelano changed the title Axum HTTP tracker: add tests for new functions Axum HTTP tracker: add tests for new Tracker functions Mar 1, 2023
@josecelano josecelano linked a pull request Mar 2, 2023 that will close this issue
Add unit tests for Tracker #210
Merged
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Mar 2, 2023
@josecelano
test(tracker): [torrust#207] add test for Tracker::announce
fca5353
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Mar 2, 2023
@josecelano
test(tracker): [torrust#207] add test for Tracker::scrape
ed58a32
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Mar 3, 2023
@josecelano
test(tracker): [torrust#207] add test for HTTP authentication in Tracker
525cd30
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Mar 3, 2023
@josecelano
test(tracker): [torrust#207] add tests for HTTP authentication in Tra…
fad6834 
…cker

The `Tracker` is responsible for the authentication in the HTTP
protocol.
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Mar 3, 2023
@josecelano
test(tracker): [torrust#207] add test for authorization (whitelist) i…
40ff249 
…n Tracker
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Mar 3, 2023
@josecelano
test(tracker): [torrust#207] add tests for torrent persistence in Tra…
af949af 
…cker
@josecelano josecelano changed the title Axum HTTP tracker: add tests for new Tracker functions Axum HTTP tracker: add unit tests for Tracker Mar 3, 2023
@josecelano josecelano changed the title Axum HTTP tracker: add unit tests for Tracker Add unit tests for Tracker Mar 3, 2023
@josecelano
Copy link
Member Author

I'm adding tests not only for new functions but for all the main tracker features.

josecelano added a commit to josecelano/torrust-tracker that referenced this issue Mar 3, 2023
@josecelano
test(tracker): [torrust#207] add tests for whitelist in Tracker
0606799
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Mar 3, 2023
@josecelano
test(tracker): [torrust#207] add tests for whitelist in Tracker
71589c4
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Mar 3, 2023
@josecelano
test(tracker): [torrust#207] add tests for whitelist in Tracker
7fb92b5
josecelano added a commit that referenced this issue Mar 4, 2023
@josecelano
Merge #210: Add unit tests for Tracker
6a15202 
d0c3054 fix(tracker): typo, rename SwamStats to SwarmStats (Jose Celano)
7fb92b5 test(tracker): [#207] add tests for whitelist in Tracker (Jose Celano)
af949af test(tracker): [#207] add tests for torrent persistence in Tracker (Jose Celano)
40ff249 test(tracker): [#207] add test for authorization (whitelist) in Tracker (Jose Celano)
fad6834 test(tracker): [#207] add tests for HTTP authentication in Tracker (Jose Celano)
d1a7b7f fix(cargo): fix output path in cargo allias (Jose Celano)
ed58a32 test(tracker): [#207] add test for Tracker::scrape (Jose Celano)
1e7eff5 docs(tracker): add code-review (Jose Celano)
d50372f feat(cargo): add cargo alias to generate coverage reports (Jose Celano)
fca5353 test(tracker): [#207] add test for Tracker::announce (Jose Celano)
ee5b088 docs(http): add comment for duplicate struct info (Jose Celano)
2ddefa8 feat: add .coverage dir to .gitignore (Jose Celano)

Pull request description:

  I'm double-checking the new Axum HTTP tracker and adding more tests.

Top commit has no ACKs.

Tree-SHA512: 78da5c5b2c121a781ad39afdad4f95e0f770f6f2567c381b38a11fcc4f52f22c907e9c8f6424bf4082c77faab4ca10876aea11301dfc7b18b02cbf26503cdb2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Quality & Assurance Relates to QA, Testing, and CI
Projects
Torrust Solution
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add unit tests for Tracker josecelano/torrust-tracker
1 participant
@josecelano