Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Expected Message to #[should_panic] tests. #391

Closed
da2ce7 opened this issue Aug 30, 2023 · 0 comments · Fixed by #397
Closed

Add Expected Message to #[should_panic] tests. #391

da2ce7 opened this issue Aug 30, 2023 · 0 comments · Fixed by #397
Labels
Easy Good for Newcomers

Comments

@da2ce7
Copy link
Contributor

da2ce7 commented Aug 30, 2023

https://rust-lang.github.io/rust-clippy/master/index.html#/should_panic_without_expect
@da2ce7 da2ce7 added the Easy Good for Newcomers label Aug 30, 2023
This was referenced Aug 30, 2023
Merged
Merged
@da2ce7 da2ce7 closed this as completed in 94aca98 Sep 5, 2023
da2ce7 added a commit that referenced this issue Sep 6, 2023
@da2ce7
Merge #363: Overhaul Containers
7d133ae 
5da5a25 dev: container overhaul (Cameron Garnham)

Pull request description:

  Depends on #391

  Ready for Review. :)

  Big Update for Containers.

  - [x] Rework Dockerfile
  - [x] Rework Container Workflow
  - [x] Rework Docker Compose File
  - [x] Rework Environmental Variables

  Todo:
  - [x] Review Documentation.
  - [x] Rebase and Make Good Commit History

  Moved to a new issue:
  - [x] Review Docker Publishing Workflows. closes #389

ACKs for top commit:
  da2ce7:
    ACK 5da5a25

Tree-SHA512: b010cae18b3934f35fa52e6d121db1631d5cae2ba48a9a4ec5c4c9f7d6b18870a6d43f3bdb6c9e412ad4f9f0a9b5625fa7e6665c75b9329ca024e4d545501552
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Easy Good for Newcomers
Projects
Torrust Solution
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Expected Should Panic Message to Tests da2ce7/torrust-tracker
1 participant
@da2ce7