-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: rename peer.updated
field in torrent detail endpoint
#61
Labels
Code Cleanup / Refactoring
Tidying and Making Neat
Comments
It seems the backend does not use it: so it would be safe to rename it, at least for other projects in the organization. It's a breaking change for external projects using only this tracker. |
josecelano
added a commit
that referenced
this issue
Nov 25, 2022
4 tasks
josecelano
added a commit
that referenced
this issue
Nov 25, 2022
josecelano
added a commit
that referenced
this issue
Nov 28, 2022
josecelano
added a commit
that referenced
this issue
Nov 28, 2022
josecelano
added a commit
that referenced
this issue
Nov 28, 2022
josecelano
added a commit
that referenced
this issue
Nov 28, 2022
josecelano
added a commit
that referenced
this issue
Nov 28, 2022
josecelano
added a commit
that referenced
this issue
Nov 29, 2022
…point e1b84f6 refactor: [#61] extract struct ApiClient for API testing (Jose Celano) bc3d246 feat(api): in torrent endpoint rename field to (Jose Celano) 7e03714 refactor: [#61] use StatsResource in API stats endpoint (Jose Celano) b974ce0 refactor: [#61] use TorrentListItemResource in torrent list API endpoint (Jose Celano) 284c91b test: [#61] add e2e test for torrent list API endpoint (Jose Celano) 7298701 refactor: [#61] extract converter from TorrentPeer to TorrentPeerResource (Jose Celano) 801dfe6 refactor: [#61] use TorrentResource in torrent info API endpoint (Jose Celano) ea92ceb test: [#61] add e2e test to API torrent info endpoint before refactoring (Jose Celano) Pull request description: TODO: - [x] Add an e2e test before refactoring. - [x] Refactor the API endpoint to use the resource `TorrentResource` like `AuthKeyResource`. - [x] Refactor endpoint ` /api/torrents?offset=:u32&limit=:u32` to use `TorrentResource`. - [x] Add a new field (`updated_milliseconds_ago`) to the JSON response keeping the old one for backwards compatibility. ACKs for top commit: josecelano: ACK e1b84f6 da2ce7: ACK e1b84f6 Tree-SHA512: be96ae16aa4214e600d6679f35a47ec3b95132ee8243352a11f7aca579a2a000843591556b8279abd073a9cb1079d32b961ee3c71892d4d925fcd202be2826a8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@WarmBeer , would not it be nice to rename the
updated
field like this:To get a json like this:
I generally like to add the units in the attribute name.
We can use any other name like:
not_updated_duration_in_msecs
,not_updated_duration_in_msecs
, ...Originally posted by @josecelano in #60 (comment)
The text was updated successfully, but these errors were encountered: