Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prefix 0x to peer ID hex string #245

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Add prefix 0x to peer ID hex string #245

merged 1 commit into from
Mar 16, 2023

Conversation

josecelano
Copy link
Member

@josecelano josecelano commented Mar 16, 2023 •
edited
Loading

A peer id like this:

peer::Id(*b"-qB00000000000000000")

has now this hex string representation:

0x2d71423030303030303030303030303030303030

with the 0x prefix as suggested by @da2ce7 here.

@josecelano josecelano force-pushed the issue-164-add-prefix-0x-to-hex-peer-id-representantion branch from ac62cc0 to d51aae0 Compare March 16, 2023 15:46
@josecelano josecelano linked an issue Mar 16, 2023 that may be closed by this pull request
Review format for peer id in announce response #164
Closed
@josecelano josecelano merged commit 0bb295c into torrust:develop Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@da2ce7 da2ce7 Awaiting requested review from da2ce7

@mickvandijke mickvandijke Awaiting requested review from mickvandijke

Assignees
No one assigned
Labels
None yet
Projects
Torrust Solution
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review format for peer id in announce response
1 participant
@josecelano