Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix single-command to run demo env with docker #365

Merged

Conversation

josecelano
Copy link
Member

@josecelano josecelano commented Aug 7, 2023

The single command provided by the documentation to run a demo with docker did not work.

See #351

This PR only fixes that command and improves a little bit the documentation.

In the short term, we need to make some improvements described here.

In the long term, we need to make UX better. See the issue #351 for some ideas about how we can make it.

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #365 (d728ddc) into develop (8f39f6e) will decrease coverage by 0.02%.
Report is 1 commits behind head on develop.
The diff coverage is 50.00%.

❗ Current head d728ddc differs from pull request most recent head 8defabd. Consider uploading reports for the commit 8defabd to get more accurate results

@@             Coverage Diff             @@
##           develop     #365      +/-   ##
===========================================
- Coverage    85.08%   85.07%   -0.02%     
===========================================
  Files           88       88              
  Lines         6564     6564              
===========================================
- Hits          5585     5584       -1     
- Misses         979      980       +1     
Files Changed Coverage Δ
src/lib.rs 64.20% <50.00%> (-0.19%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@josecelano josecelano force-pushed the issue-351-fix-docker-command-in-docs branch from d728ddc to 9a88846 Compare August 7, 2023 16:36
@josecelano josecelano force-pushed the issue-351-fix-docker-command-in-docs branch from 9a88846 to 8defabd Compare August 7, 2023 16:37
@josecelano josecelano requested a review from da2ce7 August 7, 2023 16:42
@josecelano josecelano merged commit b09e95a into torrust:develop Aug 8, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

(Docker) thread 'main' panicked at 'called Result::unwrap() on an Err value: CreatedNewConfigHalt
1 participant