Cleanup Service Initialization #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #561 +/- ##
===========================================
+ Coverage 79.25% 80.68% +1.43%
===========================================
Files 117 117
Lines 7711 7816 +105
===========================================
+ Hits 6111 6306 +195
+ Misses 1600 1510 -90 ☔ View full report in Codecov by Sentry. |
da2ce7
force-pushed
the
20231231_cleanup_service_init
branch
from
b53a219
to
108e3b5
Compare
josecelano
previously approved these changes
Jan 3, 2024
There was a problem hiding this comment.
Good work @da2ce7 I've only added a couple of comments. Regarding my comments on configuration it's something to consider for future bif refactors in configuration.
da2ce7
force-pushed
the
20231231_cleanup_service_init
branch
from
108e3b5
to
b6ce640
Compare
da2ce7
force-pushed
the
20231231_cleanup_service_init
branch
from
b6ce640
to
a12fdee
Compare
|
ACK a12fdee |
da2ce7
force-pushed
the
20231231_cleanup_service_init
branch
from
a12fdee
to
13140f6
Compare
|
ACK 13140f6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from:
Closes #560