dev: fix udp ring-buffer not looping #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #846 +/- ##
===========================================
+ Coverage 78.64% 78.78% +0.13%
===========================================
Files 163 163
Lines 9225 9252 +27
===========================================
+ Hits 7255 7289 +34
+ Misses 1970 1963 -7 ☔ View full report in Codecov by Sentry. |
|
The new test is failing on the runner but not on my machine 🤔
|
|
@josecelano I've added a little delay to the test so it will pass: |
My previous version would be limited to a single thread, as `push_overwrite` would keep on returning the last element when the ring-buffer was full. Now the ring-buffer is pre-filled and is looped over with a mutating iterator. New handles are progressively swapped-in when the old entries are finished. Note: I think that this implementation can be replaced with a standard vector with the same effect.
josecelano
force-pushed
the
842-review-process-to-abort-udp-request-when-the-ring-buffer-is-full
branch
from
abb47b2
to
9e01f7f
Compare
Updated and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@da2ce7's previous version would be limited to a single thread, as
push_overwritewould keep on returning the last element when the ring-buffer was full.Now, the ring-buffer is pre-filled and is looped over with a mutating iterator.
New handles are progressively swapped-in when the old entries are finished.
Note: I think that this implementation can be replaced with a standard vector with the same effect.