Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add privacy methods to the TrackerMode enum #871

Merged
merged 3 commits into from
May 21, 2024
Merged

Add privacy methods to the TrackerMode enum #871

merged 3 commits into from
May 21, 2024

Commits on May 21, 2024

  1. feat: [torrust#870] add privacy methods to the TrackerMode 

    The tracker mode can be:

- Public (Non-whitelisted)
- Listed (Whitelisted)
- Private (Non-whitelisted)
- PrivateListed (Whitelisted)

They should have been two different flags (in my opinion):

- Visibility: public or private
- Whitelisted: true or false

So we would have the same four convinations:

- Not whitelisted:
 - Public
 - Private
- Whitelisted
 - Public
 - Private

That's a pending refactor. For this commits, the goal is just to align
this enum with what we added to the Index so we can use this enum in the
Index via the primmitives crate.
    @josecelano
    josecelano committed May 21, 2024
    Configuration menu
    Copy the full SHA
    932e66e View commit details
    Browse the repository at this point in the history

  2. feat: [torrust#870] remove Copy trait from TrackerMode

    @josecelano
    josecelano committed May 21, 2024
    Configuration menu
    Copy the full SHA
    74d8f79 View commit details
    Browse the repository at this point in the history

  3. feat: [torrust#870] implement traits Dispaly and FromStr for TrackerMode

    @josecelano
    josecelano committed May 21, 2024
    Configuration menu
    Copy the full SHA
    0c9da2f View commit details
    Browse the repository at this point in the history