Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow invalid tracker keys #980

Conversation

josecelano
Copy link
Member

@josecelano josecelano commented Jul 30, 2024

Do not allow invalid tracker keys. Keys cannot be constructed if they:

  • Are longer than 32 chars.
  • Contain non-alphanumeric ASCII chars.

@josecelano josecelano linked an issue Jul 30, 2024 that may be closed by this pull request
@josecelano josecelano self-assigned this Jul 30, 2024
@josecelano josecelano requested a review from da2ce7 July 30, 2024 12:11
@josecelano josecelano added this to the v3.0.0 milestone Jul 30, 2024
@josecelano josecelano added the Bug Incorrect Behavior label Jul 30, 2024
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.41%. Comparing base (1f5de8c) to head (e81914b).

Files Patch % Lines
src/core/auth.rs 86.36% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #980      +/-   ##
===========================================
+ Coverage    77.40%   77.41%   +0.01%     
===========================================
  Files          184      184              
  Lines         9793     9812      +19     
===========================================
+ Hits          7580     7596      +16     
- Misses        2213     2216       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josecelano josecelano marked this pull request as ready for review July 30, 2024 16:07
@josecelano
Copy link
Member Author

ACK e81914b

@josecelano josecelano merged commit 1fdf3a8 into torrust:develop Jul 30, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Incorrect Behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: tracker keys can contain any char not only alphanumeric chars
1 participant