Overhaul tracker keys: add more tests #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was public becuase it was being used in a test but it can be used the `authenticate` method instead.
There are four ways of adding keys to the tracker. One for each combination of: - Expiring or permanent key. - Pre-generated (uploaded) ot randomdly generated key. This commit adds new tests for each case.
josecelano
force-pushed
the
989-overhaul-tracker-keys-add-more-tests
branch
from
d831d8e
to
349692b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #990 +/- ##
===========================================
+ Coverage 76.77% 77.11% +0.34%
===========================================
Files 185 185
Lines 9959 10025 +66
===========================================
+ Hits 7646 7731 +85
+ Misses 2313 2294 -19 ☔ View full report in Codecov by Sentry. |
|
ACK 349692b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are four ways of adding keys to the tracker. One for each combination of:
This PR adds new tests for each case.