Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config overhaul: use an explicit section for metadata #991

Conversation

josecelano
Copy link
Member

@josecelano josecelano commented Aug 2, 2024

The metadata section in the configuration file is changed:

TOML:

[metadata]
app = "torrust-tracker"
purpose = "configuration"
schema_version = "2.0.0"

JSON:

{
  "metadata": {
    "app": "torrust-tracker",
    "purpose": "configuration",
    "version": "2.0.0"
  }
}
  • app: the application this config file is used for.
  • purpose: the purpose of the file containing these metadata.
  • schema_version: the schema version for the file being parsed.

@josecelano josecelano self-assigned this Aug 2, 2024
@josecelano josecelano added this to the v3.0.0 milestone Aug 2, 2024
@josecelano josecelano linked an issue Aug 2, 2024 that may be closed by this pull request
@josecelano josecelano requested a review from da2ce7 August 2, 2024 09:25
The metadata section in the configuration file is changed:

TOML:

```toml
[metadata]
app = "torrust-tracker"
purpose = "configuration"
schema_version = "2.0.0"
```

JSON:

```json
{
  "metadata": {
    "app": "torrust-tracker",
    "purpose": "configuration",
    "version": "2.0.0"
  }
}
```

- `app`: the applications this config file is used for.
- `purpose`: the purpose of the file containing these metadata.
- `schema_version`: the schema version for the file being parsed.
@josecelano josecelano force-pushed the 958-config-overhaul-use-an-explicit-section-for-metadata branch from ba0f455 to 287e484 Compare August 2, 2024 09:26
@josecelano josecelano marked this pull request as ready for review August 2, 2024 09:27
@josecelano
Copy link
Member Author

ACK 287e484

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.13%. Comparing base (d47ff21) to head (287e484).

Files Patch % Lines
packages/configuration/src/lib.rs 88.88% 2 Missing ⚠️
packages/configuration/src/v2_0_0/mod.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #991      +/-   ##
===========================================
+ Coverage    77.11%   77.13%   +0.01%     
===========================================
  Files          185      185              
  Lines        10025    10036      +11     
===========================================
+ Hits          7731     7741      +10     
- Misses        2294     2295       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josecelano josecelano merged commit f95b16a into torrust:develop Aug 2, 2024
17 checks passed
@josecelano josecelano deleted the 958-config-overhaul-use-an-explicit-section-for-metadata branch August 2, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config overhaul: use an explicit section for metadata
1 participant