Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove generic parameters from Reconnect::new #755

Merged
merged 3 commits into from
Jul 20, 2024

Conversation

GlenDC
Copy link
Contributor

@GlenDC GlenDC commented Dec 5, 2023

these were not used, as the only parameters used
come from the impl block (directly and indirectly)

Closes #737

these were not used, as the only parameters used
come from the impl block (directly and indirectly)
@tobz tobz added A-reconnect Area: The tower "reconnect" middleware C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Jul 20, 2024
@tobz tobz merged commit 7d723eb into tower-rs:master Jul 20, 2024
14 checks passed
@tobz tobz added relnotes Marks issues that should be documented in the release notes of the next release. S-awaiting-release Status: approved/merged but awaiting a release. labels Jul 20, 2024
@tobz
Copy link
Member

tobz commented Aug 13, 2024

This has been released as part of tower@v0.5.0.

Thanks again for your contribution!

@tobz tobz removed the S-awaiting-release Status: approved/merged but awaiting a release. label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-reconnect Area: The tower "reconnect" middleware C-cleanup Category: PRs that clean code up or issues documenting cleanup. relnotes Marks issues that should be documented in the release notes of the next release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reconnect::new() Generic parameters are redundant
2 participants