Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fix for #296 #297

Merged
merged 9 commits into from
Jan 17, 2023
Merged

Add fix for #296 #297

merged 9 commits into from
Jan 17, 2023

Conversation

hoodmane
Copy link
Collaborator

@hoodmane hoodmane commented Jan 17, 2023 •
edited
Loading

See the explanation in the diff and in issue #296.

Resolves #296.

@hoodmane
Copy link
Collaborator Author

Well that doesn't seem to work...

gaborbernat
gaborbernat requested changes Jan 17, 2023
View reviewed changes
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to fix the CI 🤔

@gaborbernat
Copy link
Member

Almost just need to fix CI on 3.7 and 3.8!

@gaborbernat gaborbernat merged commit 2cea8d4 into tox-dev:main Jan 17, 2023
@hoodmane hoodmane deleted the overloads branch January 17, 2023 18:07
@hoodmane hoodmane mentioned this pull request Jan 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborbernat gaborbernat gaborbernat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doesn't interact correctly with typing.overload.
2 participants
@hoodmane @gaborbernat