Fix issue #462 and another alias processing bug #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix processing type aliases
for more information, see https://pre-commit.ci
tikuma-lsuhsc
changed the title
hoodmane
reviewed
Jun 21, 2024
Comment on lines
+197
to
+198
| if isinstance(annotation, TypeAliasForwardRef): | ||
| return str(annotation) |
There was a problem hiding this comment.
Should we check whether we can make an xref here? Perhaps in a followup.
There was a problem hiding this comment.
sorry, I'm not following. Could you elaborate?
There was a problem hiding this comment.
wait I messed up the review process. I didn't mean to dismiss your review. my bad
hoodmane
approved these changes
Jun 21, 2024
hoodmane
previously approved these changes
Jun 21, 2024
gaborbernat
approved these changes
Jun 21, 2024
hoodmane
approved these changes
Jun 21, 2024
|
Thanks @tikuma-lsuhsc! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bugs introduced in v2.2:
The new alias look up mechanism follows closely as done in
sphinx.util.inspect.signature()