Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering when docstring starst with a directive #468

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

hoodmane
Copy link
Collaborator

We want to position our insertion before the directive but we incorrectly get a negative insertion line. This inserts at the end rather than at the beginning, and we fail to leave the correct empty line after the directive.

Resolves #467

Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need to fix the CI 👍

@hoodmane
Copy link
Collaborator Author

Opened #469 since the failure is on the main branch.

We want to position our insertion before the directive but we incorrectly get a
negative insertion line. This inserts at the end rather than at the beginning,
and we fail to leave the correct empty line after the directive.

Resolves tox-dev#467
@gaborbernat gaborbernat merged commit a427536 into tox-dev:main Jul 17, 2024
9 checks passed
@hoodmane hoodmane deleted the fix-seealso branch July 17, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflict with directives seealso, deprecated, ...
2 participants