Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for external packages and builders #2235

Merged
merged 6 commits into from
Sep 26, 2021

Conversation

gaborbernat
Copy link
Member

@gaborbernat gaborbernat commented Sep 25, 2021

Resolves #2204

  • Install package support
  • Introduce children package envs
  • Add sdist + wheel metadata extractor

Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
Instead of a runner having multiple package envs let package envs have
children package envs. This allows the external wheel builder have
package metadata builder child package envs.

Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
@gaborbernat gaborbernat added this to the 4.0 milestone Sep 25, 2021
@gaborbernat gaborbernat changed the title 2204 Support for external packages and builders Sep 25, 2021
@codecov
Copy link

codecov bot commented Sep 25, 2021

Codecov Report

Merging #2235 (243f238) into rewrite (d448d82) will decrease coverage by 0.00%.
The diff coverage is 99.80%.

Impacted file tree graph

@@             Coverage Diff             @@
##           rewrite    #2235      +/-   ##
===========================================
- Coverage    99.81%   99.80%   -0.01%     
===========================================
  Files          164      169       +5     
  Lines         9553     9791     +238     
  Branches       980     1001      +21     
===========================================
+ Hits          9535     9772     +237     
- Misses           7        8       +1     
  Partials        11       11              
Flag Coverage Δ
tests 99.80% <99.80%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/tox/tox_env/python/pip/pip_install.py 100.00% <ø> (ø)
.../tox_env/python/virtual_env/test_virtualenv_api.py 100.00% <ø> (ø)
src/tox/tox_env/package.py 97.50% <87.50%> (-2.50%) ⬇️
src/tox/execute/pep517_backend.py 100.00% <100.00%> (ø)
src/tox/plugin/manager.py 100.00% <100.00%> (ø)
src/tox/pytest.py 100.00% <100.00%> (ø)
src/tox/session/cmd/run/single.py 100.00% <100.00%> (ø)
src/tox/session/state.py 100.00% <100.00%> (ø)
src/tox/tox_env/api.py 100.00% <100.00%> (ø)
src/tox/tox_env/python/package.py 100.00% <100.00%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d448d82...243f238. Read the comment docs.

Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
@gaborbernat gaborbernat marked this pull request as ready for review September 26, 2021 00:54
Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants