do not remove too many chars on uncommenting #93
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbra
force-pushed
the
fix_uncomment
branch
from
b832a22
to
b711909
Compare
|
updated to latest changes |
If the text is not consistently commented like this: #- Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor # incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis # nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. # Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu # fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in # culpa qui officia deserunt mollit anim id est laborum. using gcu will remove the leading - on the first line. (`:set cms=#%s`) That is, because in the first for loop, the l will be set to not include the leading slash, however after the first iteration, it will be overwritten and contain '# ' (e.g. 2 chars). Then on uncommenting, the first two characters will be unconditionally removed. Fix this, by remembering the shortest match to remove. references tpope#92
chrisbra
force-pushed
the
fix_uncomment
branch
from
b711909
to
f0b11d7
Compare
Closed
|
#82 appears to have fixed this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the text is not consistently commented like this:
using gcc will remove the leading - on the first line.
That is, because in the first for loop, the l will be set to not include
the leading slash, however after the first iteration, it will be
overwritten and contain '# ' (e.g. 2 chars). Then on uncommenting,
the first two characters will be unconditionally removed.
Fix this, by remembering the shortest match to remove.
references #92