chore: use feat instead of chore with renovate pr
#1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloiseleur
changed the title
mloiseleur
changed the title
feat instead of chore with renovate pr
There was a problem hiding this comment.
Per documentation (https://www.conventionalcommits.org/en/v1.0.0/).
feat: a commit of the type feat introduces a new feature to the codebase (this correlates with MINOR in Semantic Versioning).
Per https://github.com/angular/angular/blob/22b96b9/CONTRIBUTING.md#type and https://github.com/angular/angular/commits/main I would advocate for build, WDYT ?
|
This is how it's handled by our release workflow: https://github.com/mathieudutour/github-tag-action/blob/9d35d648e836d5db77936aa35a3a5c7bc16092c8/src/defaults.ts#L30 |
darkweaver87
force-pushed
the
fix/renovate-commit-msg
branch
from
8da1fb8
to
b2433cc
Compare
mloiseleur
commented
Aug 27, 2024
traefiker
force-pushed
the
fix/renovate-commit-msg
branch
from
d6b2929
to
530d458
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Change Renovate PR title from
chore(deps): ...tofeat(deps): ...Motivation
Release notes should display version update of Traefik Proxy in this Chart.