Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT B-19809 update SC flag count to include missing orders info #13676

Merged

Conversation

danieljordan-caci
Copy link
Contributor

Agility ticket

Summary

We want to include the count of missing orders information in the count of action items for both the TOO and SC when navigating the application.

We also want to replace the red exclamation with a red box with the count of missing orders info.

This PR does the following:

  • adds state to both ServicesCounselingMoveInfo and TXOMoveInfo to keep track of the count of missing fields in the orders object - this is the parent component of the components we need to use those values in
  • passes those state values as props to MoveDetails & ServicesCounselingMoveDetails aaaand TXOTabNav & ServicesCounselingTabNav - also includes the setter functions to manage those values with a useEffect hook
  • updates the Tag with color value from colors.scss to maintain continuity in the applicaiton
  • adds/updates relevant tests

How to test

  1. Access MM as a SC or TOO
  2. Find a move that has missing orders information
  3. Confirm that the count of missing order fields is included in the Move Details count tab
  4. Confirm there is a red box with the count in the left nav bar when in the Move Details tab

Screenshots

TOO view
Screenshot 2024-09-10 at 11 19 31 AM

SC view
Screenshot 2024-09-10 at 11 23 06 AM

508 for TOO
Screenshot 2024-09-10 at 11 20 22 AM

508 for SC
Screenshot 2024-09-10 at 11 20 40 AM

@danieljordan-caci danieljordan-caci added Mountain Movers Movin' Mountains 1 Sprint at a time INTEGRATION Slated for Integration Testing labels Sep 10, 2024
@danieljordan-caci danieljordan-caci self-assigned this Sep 10, 2024
@danieljordan-caci danieljordan-caci requested a review from a team as a code owner September 10, 2024 16:29
Copy link
Contributor

@traskowskycaci traskowskycaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described, code looks good, meets AC. Nice!
image

Copy link
Contributor

@TevinAdams TevinAdams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected and ACs met

@danieljordan-caci danieljordan-caci merged commit b1cec9f into integrationTesting Sep 11, 2024
30 checks passed
@danieljordan-caci danieljordan-caci deleted the INT-B-19809-add-SC-flags-for-orders branch September 11, 2024 18:11
@traskowskycaci traskowskycaci restored the INT-B-19809-add-SC-flags-for-orders branch September 13, 2024 15:00
@traskowskycaci traskowskycaci mentioned this pull request Sep 13, 2024
1 task
@paulstonebraker
Copy link
Contributor

image
Moves without uploaded orders don't show any flags, but can't be submitted - should that be included in this work or is it out of scope?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTEGRATION Slated for Integration Testing Mountain Movers Movin' Mountains 1 Sprint at a time
Development

Successfully merging this pull request may close these issues.

4 participants