B 21041 Prime can update existing second/third addresses #13701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
paulstonebraker
requested review from
loganwc,
joeydoyecaci,
pambecker and
JonSpight
pambecker
reviewed
Sep 20, 2024
| return mtoshipmentops.NewUpdateMTOShipmentAddressUnprocessableEntity().WithPayload(payloads.ValidationError( | ||
| "This shipment is approved, please use the updateShipmentDestinationAddress endpoint to update the destination address of an approved shipment", h.GetTraceIDFromRequest(params.HTTPRequest), nil)), err | ||
| } | ||
|
|
||
| if dbShipment.ShipmentType == models.MTOShipmentTypeHHGOutOfNTSDom && | ||
| (*dbShipment.PickupAddressID == addressID) { | ||
| (dbShipment.PickupAddressID != nil && *dbShipment.PickupAddressID == addressID) { |
There was a problem hiding this comment.
This line is different than what was merged into integration.
*dbShipment.PickupAddressID != uuid.Nil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agility ticket
INT PR
Note
I didn't follow best practices and update my main branch and merge that into my integration branch for the final commit, so please pay close attention to changes to mto_shipment_address.go
Summary
Part of the effort to allow prime to view/update/add third addresses (also includes the work to add second addresses). This work allows prime to update addresses for existing shipments that have second/third addresses. In planning my approach, I thought it would be quicker to refactor the existing Prime UI update address component, and make it better for those of us who use Prime SIM, so I took the liberty of doing that. Now, when you click update on an address, it will take you an update address page for that specific address.
How to test
Setup: if 21054 has not been merged you will either need a move with shipments of all types, with second/third pickup/delivery addresses
NOTE: NTS/NTSR will not update if a primary pickup or destination address is missing, its an existing bug
NOTE: HHG Primary destination addresses will not update, as they have a separate endpoint to use
NOTE: Updating PPM second/third addresses is being handled in 21054