INT B-19044

[traskowskycaci]

Agility ticket

Summary

These are to make the counts on the left nav and top nav bar more useful to the office users. Daniel did the implementation here and had some back and forth with the gov via slack, if we need to reference it.

• Counselor remarks are no longer included in the count for tasks
• Actions that block the office user from processing are now red notifications
• Other required actions are yellow

Testing AC 1:
GIVEN that I am a Service Counselor viewing "Shipments" on the "Move details" page
WHEN there are no counselor remarks,
THEN I will not be required to enter counselor remarks,
AND this item will not be included in the count of items that need my attention.

1. Create a PPM move as the customer, request an advance
2. Log in as the counselor
3. See that the counselor remarks no longer have a yellow mark and are not included in the total count
   

Testing AC 2:
GIVEN that I am a Service Counselor viewing "Shipments" on the "Move details" page
AND a customer has a PPM shipment,
WHEN the "Advance requested?" field has not been reviewed,
THEN I will see a red indicator that the item needs my attention,
AND this item is included in the count of items that need attention for the "Shipments" section in the left nav bar,
AND this item is included in the count of items that need attention for the "Move details" page in the top nav bar.

1. Use the move you just created as long as it has a requested advance (if you forgot, just make a new one)
2. Notice that since the Advance Rqeuested field has not been reviewed by the counselor, the Shipments left nav tag will have a red '1' by it.
   
   

Testing AC 3:
GIVEN that I am a TOO viewing "Shipments" on the "Move details" page
AND a customer has a PPM shipment that requires GHC Prime Counseling,
WHEN the "Advance requested?" field has not been reviewed,
THEN I will see a red indicator that the item needs my attention,
AND this item is included in the count of items that need attention for the "Shipments" section in the left nav bar,
AND this item is included in the count of items that need attention for the "Move details" page in the top nav bar.

1. Switch to the TOO role
2. Search for the same move you just looking at, by move code
3. Notice that since the Advance Rqeuested field has not been reviewed, and the Shipments left nav tag will have a red '1' by it.
   

Testing AC 4:
GIVEN that I am a Services Counselor,
WHEN I am viewing "Allowances" on the "Move details" page,
THEN I will not see orange indicators for Pro-gear, Spouse pro-gear, Required medical equipment, OCIE, and Gun Safe.

1. Log in as a services counselor
2. Confirm you don't see orange indicators on the Allowances section
   

Screenshots

[cameroncaci]

Works like a charm, meets all AC, code looks good

[TevinAdams]

Tested and Reviewed.