B-20947 Fix: Apply GCC calculation Fix to Payment Packet #13734
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agility ticket
Issue Ticket I-13317
Main PR for B-20947
Summary
When working B-20947 the calculation fix was applied to AOA Packets but not the Payment Packets. So the payment packets are still showing the incorrect value but the AOA packet is now showing the correct value. This was just a missed AC because payment packet was referred to as "PPM SSW". In This PR I am applying the same calculation fix for the AOA packet to the payment packet as well. Both are supposed to use the same calculations according to the ACs. Solves issue I-13317.
Is there anything you would like reviewers to give additional scrutiny?
this article explains more about the approach used.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
How to test
If:
Entitlement = 5000
TotalWeight = 7500
Actual Weight = 4000
Then 100% GCC should equal 4000lbs
If:
Entitlement = 5000
TotalWeight = 7500
Actual Weight = 6000
Then 100% GCC should equal 5000lbs
You can add weight tickets as a customer by going to a customer with a PPM Shipment and following step 6:
Frontend
officeApp
class or custommin-width
styling is used to hide any states the would not be visible to the user.Backend
Database
Any new migrations/schema changes:
Screenshots