Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B-20947 Fix: Apply GCC calculation Fix to Payment Packet #13734

Merged

Conversation

TevinAdams
Copy link
Contributor

@TevinAdams TevinAdams commented Sep 17, 2024

Agility ticket

Issue Ticket I-13317

Main PR for B-20947

Summary

When working B-20947 the calculation fix was applied to AOA Packets but not the Payment Packets. So the payment packets are still showing the incorrect value but the AOA packet is now showing the correct value. This was just a missed AC because payment packet was referred to as "PPM SSW". In This PR I am applying the same calculation fix for the AOA packet to the payment packet as well. Both are supposed to use the same calculations according to the ACs. Solves issue I-13317.

Is there anything you would like reviewers to give additional scrutiny?

this article explains more about the approach used.

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

How to test

  1. Access office as a service counselor
  2. Select a PPM Closeout move
  3. Make sure to approve all the documents as a counselor so the Payment Packet link will show
  4. while under Move Details Tab scroll down and select "Download Payment Packet (PDF)"
  5. Once downloaded inspect the 100% GCC value under Actual Obligations section under the Entitlements & move summary
  6. The value should be the actual weight up to the (entitlement weight or allowed weight) whichever is lessor. The value should also not include any Progear. For Example:

If:
Entitlement = 5000
TotalWeight = 7500
Actual Weight = 4000
Then 100% GCC should equal 4000lbs

If:
Entitlement = 5000
TotalWeight = 7500
Actual Weight = 6000
Then 100% GCC should equal 5000lbs

You can add weight tickets as a customer by going to a customer with a PPM Shipment and following step 6:
image

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Backend

Database

Any new migrations/schema changes:

  • Follows our guidelines for Zero-Downtime Deploys.
  • Have been communicated to #g-database.
  • Secure migrations have been tested following the instructions in our docs.

Screenshots

@TevinAdams TevinAdams added the INTEGRATION Slated for Integration Testing label Sep 17, 2024
@TevinAdams TevinAdams self-assigned this Sep 17, 2024
@TevinAdams TevinAdams requested a review from a team as a code owner September 17, 2024 20:50
@TevinAdams TevinAdams marked this pull request as draft September 17, 2024 20:50
@TevinAdams TevinAdams added the Mountain Movers Movin' Mountains 1 Sprint at a time label Sep 17, 2024
@TevinAdams TevinAdams marked this pull request as ready for review September 18, 2024 13:09
Copy link
Contributor

@traskowskycaci traskowskycaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described

image

@TevinAdams TevinAdams merged commit 8c70e18 into integrationTesting Sep 19, 2024
30 checks passed
@TevinAdams TevinAdams deleted the INT-B-20947-GCC-Calculations-Payment-Packet branch September 19, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTEGRATION Slated for Integration Testing Mountain Movers Movin' Mountains 1 Sprint at a time
Development

Successfully merging this pull request may close these issues.

3 participants