Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stg daily add #135

Merged
merged 27 commits into from
Aug 13, 2024
Merged

Stg daily add #135

merged 27 commits into from
Aug 13, 2024

Conversation

edwardxtg
Copy link
Contributor

Description

Please explain the changes you made here.

Checklist

  • Dependencies install correctly in a clean environment and code executes;
  • Test coverage extended; created tests fail without the change (if possible);
  • All tests passing;
  • Commits follow a type convention (e.g. https://gist.github.com/brianclements/841ea7bffdb01346392c#type);
  • Extended the README, documentation and/or docstrings, if necessary;

Copy link

@edwardxtg edwardxtg marked this pull request as ready for review August 7, 2024 15:05
@edwardxtg edwardxtg requested a review from djwels August 7, 2024 15:05
Copy link
Contributor

@djwels djwels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Tested on larger model (1 node Philippines)
  • storage_balance_day (when tagged to true) is leading to errors in construction
  • Suggest going back to commit from yesterday where constraint was working and we can go from there?

Copy link
Contributor

@djwels djwels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Tested in both smaller python test scripts and in larger models
  • Both annual and daily balancing behaving as expected i.e. balancing across the daily time brackets for daily = true and across each year for annual = true

@edwardxtg edwardxtg merged commit 5c36278 into main Aug 13, 2024
3 checks passed
@edwardxtg edwardxtg deleted the stg_daily_add branch August 13, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants