[SMS-263] commodity construction #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: rm otoole sample data from tests * feat: import utils by name * fix: cleanup some DS store * fix: import utils
…sition Merge in otoole_roundtrip test
edwardxtg
reviewed
Feb 21, 2024
There was a problem hiding this comment.
@Lkruitwagen I've tested locally and is working well as is.
When enabling the test_otoole_roundtrip test it bugs, would you like me to look into this or would you rather keep adding construction tests and address any issues later? (as per our convo will not worry about the roundtrip test for now)
edwardxtg
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some initial refactoring of otoole compatability to a
schemas/compat/folder