Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SMS-307] feat compat storage #52

Merged
merged 25 commits into from
Mar 13, 2024
Merged

[SMS-307] feat compat storage #52

merged 25 commits into from
Mar 13, 2024

Conversation

edwardxtg
Copy link
Contributor

@edwardxtg edwardxtg commented Mar 8, 2024 •
edited
Loading

Storage example data, compat and tests added.

@notion-workspace Notion Workspace
Copy link

Feature/storage

@Lkruitwagen
Copy link
Contributor

okay it's dying on TechnologyToStorage and TechnologyFromStorage. We need to create OSeMOSYSData subclasses that have composeable storage sets. But I'd also like to check with Abhi how storage works - its a little confusing to me.

@edwardxtg edwardxtg marked this pull request as ready for review March 12, 2024 17:23
@edwardxtg
Copy link
Contributor Author

Ready for review @Lkruitwagen

@Lkruitwagen Lkruitwagen changed the title Sms 307 feat compat storage [SMS-307] feat compat storage Mar 13, 2024
@edwardxtg edwardxtg merged commit 8779c88 into main Mar 13, 2024
2 checks passed
@edwardxtg edwardxtg deleted the sms-307-feat-compat-storage branch March 13, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lkruitwagen Lkruitwagen Lkruitwagen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edwardxtg @Lkruitwagen