Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading additional batches with Transloadit is broken allowMultipleUploadBatches: true #5397

Closed
2 tasks done
719media opened this issue Aug 9, 2024 · 1 comment · Fixed by #5400
Closed
2 tasks done
Labels
Bug prio-1 High-priority issues

Comments

@719media
Copy link

719media commented Aug 9, 2024

Initial checklist

  • I understand this is a bug report and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Link to runnable example

No response

Steps to reproduce

const uppyInstance = new Uppy({
  allowMultipleUploadBatches: true,
  autoProceed: true,
}).use(Transloadit, {
  waitForEncoding: true,
  assemblyOptions: {
    params: {
      auth: { key: TRANSLOADIT_AUTH_KEY },
      template_id: TEMPLATE_ID,
    },
  },
});

Set up transloadit like this, upload some files, then do it again. You will get an error: tus: neither an endpoint or an upload URL is provided

See community post made by someone else with issue as well:
https://community.transloadit.com/t/getting-error-while-uploading-second-batch-of-files-in-uppy/17201

Isolated this behavior as starting to occur with uppy v4 release

Expected behavior

Upload should work

Actual behavior

Upload fails

@719media 719media added the Bug label Aug 9, 2024
@mifi mifi changed the title uppy with transloadit throws error on 2nd (4th, 6th, etc.) attempt at upload Uploading additional batches with Transloadit is broken (allowMultipleUploadBatches: true) Aug 9, 2024
@mifi mifi changed the title Uploading additional batches with Transloadit is broken (allowMultipleUploadBatches: true) Uploading additional batches with Transloadit is broken allowMultipleUploadBatches: true Aug 9, 2024
@mifi mifi added the prio-1 High-priority issues label Aug 9, 2024
@mifi
Copy link
Contributor

mifi commented Aug 9, 2024

I can confirm this is broken, and it only happens with allowMultipleUploadBatches: true.

mifi added a commit that referenced this issue Aug 9, 2024
fixes #5397
also refactor from promise.then to async/await
and fix what seems like broken logic with recursive this.#afterUpload call
aduh95 pushed a commit that referenced this issue Aug 15, 2024
fixes #5397
also refactor from promise.then to async/await
and fix what seems like broken logic with recursive this.#afterUpload call
@aduh95 aduh95 closed this as completed in 013f4ea Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug prio-1 High-priority issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants