Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--- FAIL: TestBroker_RemovePeer: race detected during execution of test #27

Closed
davecheney opened this issue Feb 12, 2017 · 5 comments
Closed

Comments

@davecheney
Copy link

http://paste.ubuntu.com/23985334/

@travisjeffery
Copy link
Owner

Seems to be fixed after merging a change that split the serf and raft pkgs from the broker's pkg—because they don't access the same peers map anymore. I was able to reproduce it before but can't now. Thanks for making the issue.

@davecheney
Copy link
Author

davecheney commented Feb 13, 2017 via email

@travisjeffery travisjeffery reopened this Feb 13, 2017
@travisjeffery
Copy link
Owner

So you pulled and reproduced it after I left that comment? Just checking in case you're looking at the dates of when the commits were made rather than when they were merged into master.

@davecheney
Copy link
Author

davecheney commented Feb 13, 2017 via email

@travisjeffery
Copy link
Owner

travisjeffery commented Feb 13, 2017

Yeah that commit's behind. See where it in relation to the other commits here: https://github.com/travisjeffery/jocko/commits/master, or the compare: fee05bf...master

Absolutely. I was gonna add it, but it'd cool if you wanted to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants