Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ssl option to RemoteDatabaseConfig #1690

Merged
merged 5 commits into from
Jul 29, 2022
Merged

Add ssl option to RemoteDatabaseConfig #1690

merged 5 commits into from
Jul 29, 2022

Conversation

gumigumi4f
Copy link
Contributor

We are trying to connect background postgresql database with server and client certificates. (Ex: Google Cloud SQL)
But there is no option to change sslfactory and sslmode and we cannot connect database.

After merging this PR, we are able to connect postgresql with certificates by adding the following settings and placing the certificates to ${user.home}/.postgresql/.

database.ssl = true
database.sslfactory = org.postgresql.ssl.LibPQFactory
database.sslmode = verify-ca

@yoyama
Copy link
Contributor

yoyama commented Apr 15, 2022

@gumigumi4f Thank you for your contribution.
I think we should update the document for new configuration.
https://docs.digdag.io/command_reference.html#server
You can update the doc in digdag-docs directory.

@yoyama yoyama self-requested a review April 15, 2022 01:20
yoyama
yoyama requested changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@yoyama yoyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As comment, please update document.

@yoyama yoyama added this to the v0.10.5 milestone Apr 18, 2022
@gumigumi4f
Copy link
Contributor Author

Sorry for late response.
I have added new option such as sslcert and updated digdag-docs.

@gumigumi4f
Copy link
Contributor Author

gumigumi4f commented Jul 22, 2022 •
edited
Loading

I have updated the docs.

@yoyama yoyama self-requested a review July 28, 2022 08:50
@yoyama
Copy link
Contributor

yoyama commented Jul 28, 2022

Thank you for your contribution. After CI has passed, I will approve it.

yoyama
yoyama approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@yoyama yoyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thank you for your contribution

@yoyama yoyama merged commit 453a36a into treasure-data:master Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoyama yoyama yoyama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.10.5
Development

Successfully merging this pull request may close these issues.
2 participants
@gumigumi4f @yoyama