Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[digdag-ui] added a button to copy logs to clipboard #1760

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

kyoppii13
Copy link
Contributor

@kyoppii13 kyoppii13 commented Jul 23, 2022

Overview

fix #1538

I added a button to copy logs to clipboard on the attempts and sessions page.

The button appears only when hovering over the log area.
I put a blank space at the top of the log area so that the buttons and logs do not overlap.

Why?

#1538

Demo

Movie

digdag.mov

Images

When mouseover on a log area
スクリーンショット 2022-07-24 11 43 22

When mouseover on a copy button
スクリーンショット 2022-07-24 11 43 32

@kyoppii13 kyoppii13 changed the title [WIP] add code copy btn [digdag-ui] added a button to copy logs to clipboard Jul 24, 2022
@yoyama yoyama added this to the v0.10.5 milestone Jul 27, 2022
@yoyama yoyama self-requested a review July 28, 2022 08:47
Copy link
Contributor

@yoyama yoyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thank you for your contribution.

@yoyama yoyama merged commit 5bb2b5b into treasure-data:master Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Button to copy entire logs to paseboard in Session / Attempt page in digdag UI
2 participants